rust-bitcoin / rust-bitcoin / 14885596078

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4409: Manual update to rustc (to nightly-2025-05-02)

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/5ba763f1a2ebea2cb80ee50a80228e6bda11936f">5ba763f1a<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6adf952b0b50c64b97534c188a97ffbe5614856a"> Update Github CI to rustc nightly-2025-05-02 (Jamil Lambert, PhD)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/09132b80e11c51124e58610d2d98d25001df72b2">09132b80e</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6adf952b0b50c64b97534c188a97ffbe5614856a"> Fix rustdoc compile_fail example (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/282434d4bd23618d57bd7ed1abfa58ac3e48a557">282434d4b</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6adf952b0b50c64b97534c188a97ffbe5614856a"> Use variable directly in format! string (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2fbbc825c97d1fd8f710b0a2474946656d78979a">2fbbc825c</a> Allow uninlined format args (Jamil Lambert, PhD)

Pull request description:

  There is a new lint error on nightly-2025-04-25 "variables can be used directly in the `format!` string".
  The existing syntax `format!("{}", x)` is more commonly used than `format!("{x}")` therefore allow it in existing code.

  Also the rustdoc example in #4259 now causes the new nightly to fail CI because of the unused variable.

  Patches in the PR:

  - Exclude the lint to allow the existing syntax in `format!` strings in all crate `lib.rs`, `build.rs.` and test files.

  - Use the variables in the `format!` string for all cases in `bitcoin/examples/` since there are no other allowed lints in examples.

  - Correct the function names in the rustdoc example and prefix the unused variable with an underscore.

  - Update rustc to nightly-2025-05-02 (2025-04-25 had a bug which is fixed in 2025-05-02).

ACKs for top commit:
  apoelstra:
    ACK 5ba763f1a2ebea2cb80ee50a80228e6bda11936f; successfully ran local tests
  Kixunil:
    ACK 5ba763f1a2ebea2cb80ee50a80228e6bda11936f

Tree-SHA512: 20b97d2bef2f11d72832aaceaadd5e50d5a

22964 of 27259 relevant lines covered (84.24%)

16249.53 hits per line