UiPath / uipathcli / 14878614187

91%

main: 91%

Build Type

Pull #191

github

Committed by thschmitt

Commit Message

Move URI formatting logic from plugins into UriBuilder

Each plugin has been doing some custom formatting of the URI and
replacing organization and tenant. Moved all the logic for URI handling
in the API clients which use the `uri_builder.go`.

Changed all the code which uses the baseUri to make use of url.URL
instead of strings which allowed removing the `NewUriBuilder` method
which used to convert the baseUri string.

Noticed that the UriBuilder does not espace all URI parts properly.
Added escaping for path and query string keys.

Added more tests to validate the url formatting to avoid similar issues
like https://github.com/UiPath/uipathcli/issues/189.

Pull Request Pull Request #191: Move URI formatting logic from plugins into UriBuilder

Run Details

160 of 163 new or added lines in 15 files covered. (98.16%)

1 existing line in 1 file now uncovered.

6421 of 7092 relevant lines covered (90.54%)

1.02 hits per line