307
76%

Ran 03 May 2014 12:43PM UTC

Jobs 1

Files 50

Run time 11s

Badge

Embed ▾

pending completion

Build # 307

Build Type

Pull #162

travis-ci

Committed by

divdavem

Commit Message

Removes unnecessary global var access when cpt path is in local scope

Consider the following template:

# template myTpl using c:Ctrl
  <#c.tpl />
# /template

Before this commit, the compiler was generating the following code:

var myTpl = require("hsp/rt").template({ctl:[Ctrl,"Ctrl"],ref:"c"}, function(n){
var _c;try {_c=c} catch(e) {};
return [n.cpt([_c,"c","tpl"],0,0,0)];
});

Note the unexpected access to the global c variable, which is
stored in _c in a try...catch block.

As we know the c variable is in the scope in this case, this commit
changes the compiler to generate the following code instead:

var myTpl = require("hsp/rt").template({ctl:[Ctrl,"Ctrl"],ref:"c"}, function(n){
return [n.cpt([null,"c","tpl"],0,0,0)];
});

Pull Request Pull Request #162: Removes unnecessary global var access when cpt path is in local scope

Run Details

3768 of 4187 relevant lines covered (89.99%)

170.18 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
9	95.51	0.07%	./hsp/compiler/jsgenerator/processors.js

Jobs

ID	Job ID	Ran	Files	Coverage
1	307.1	03 May 2014 12:43PM UTC	57	87.09	Travis Job 307.1

Source Files on build 307

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

ariatemplates / hashspace / 307
76%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 307

ariatemplates / hashspace / 307 76%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 307

ariatemplates / hashspace / 307
76%

README BADGES
x