zhmcclient / zhmccli / test-1818

39%

Build Type

push

github

Committed by andy-maier

Commit Message

Fixed CeasedExistence in 'partition list-storagegroups'; Consolidated prop proc.

* Fixed the CeasedExistence error for the 'zhmc partition list-storagegroups'
  command when the logged-on user had no object access permission to a storage
  group attached to the partition.

* Removed the incorrect 'device-number' property from the output of the
  'zhmc storagegroup list' command.

* Consolidated resource property processing between table output and json/csv
  output formats. They now use a common function to determine the resource
  properties. This changes the order of properties for the csv and json output
  formats. The properties are now consistently sorted as follows:
  The properties shown in the default output are in a specific order. Additional
  properties shown by specifying `--all` are placed after the default properties
  and are sorted by name.

* Internal changes:
  - Clarified and fixed description of sort_prop and show_list parameters
    of print functions in _helper.py.
  - Made the show_list parameter required in print_resources...() functions,
    because it is always specified and allowing None just makes the code
    more complex.
  - Removed the all parameter from print_dicts...() functions, because it is
    redundant to show_list being None. Adjusted the calls to print_dicts()
    accordingly in several command modules.
  - Removed the sort parameter in get_resource_list(), because the properties
    specified in show_list are never sorted, and the additional properties
    added by all are always sorted.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>

Run Details

24 of 36 new or added lines in 1 file covered. (66.67%)

4 existing lines in 1 file now uncovered.

3425 of 8602 relevant lines covered (39.82%)

3.58 hits per line