ThePalaceProject / web-patron / 14845643120

77%

push

github

PP-2463 : [bugfix] pressing enter from login barcode or password input would not initiate login (#65)

## Description

<!--- Describe your changes -->
The login screen has a button that toggles the visibility for a user's
password. The type for this button has been explicitly set as `button`.

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
Any buttons nested within a `<form/>` will have `type="submit"` by
default if no type is specified. The original click handler for the
password visibility toggle overrode the form's default behavior, so any
submit event within the form would not work as intended and would only
toggle password visibility. Adding `type="button"` to the password
visibility button separated the button's behavior from the form and
allows an `Enter` keydown to submit from anywhere within the form unless
a user is focused on the password visibility button.
<!--- If it fixes an open issue, please link to the issue here. -->

[Jira PP-2463](https://ebce-lyrasis.atlassian.net/browse/PP-2463)

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [N/A] I have updated the documentation accordingly.
- [x] All new and existing tests passed.

801 of 1041 branches covered (76.95%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1387 of 1567 relevant lines covered (88.51%)

30.02 hits per line