ti-mo / conntrack / 14836725940

92%

push

github

Add to wait group prior to starting event worker

When calling Listen and Close in quick succession repeatedly, the
previous code would occasionally panic with:

sync: WaitGroup is reused before previous Wait has returned

From the Go doc on WaitGroup.Add:

Typically this means the calls to Add should execute before the
statement creating the goroutine or other event to be waited for.

By moving the call to Add just before starting the event worker
goroutine, this commit ensures calls to Wait will not panic under load.

1 of 1 new or added line in 1 file covered. (100.0%)

1333 of 1456 relevant lines covered (91.55%)

1862.47 hits per line