rust-bitcoin / rust-bitcoin / 14826077838

83%

Build Type

push

github

Committed by tcharding

Commit Message

Merge rust-bitcoin/rust-bitcoin#4431: units: rename relative locktime types, absolute::Time, and constructors

826acb827 units: rename relative::HeightInterval constructors (Andrew Poelstra)
39b4f7670 units: rename relative::Height to HeightInterval (Andrew Poelstra)
d3619cc1b units: deprecate relative::MtpInterval::to_consensus_u32 (Andrew Poelstra)
1a6b8b4c7 units: rename relative::Time to MtpInterval (Andrew Poelstra)
39b057fad units: rename absolute::Height consensus functions (Andrew Poelstra)
5a8f33f38 units: rename absolute::Mtp consensus functions (Andrew Poelstra)
8ffcd2cf3 units: rename absolute::Time to absolute::Mtp (Andrew Poelstra)

Pull request description:

  This PR does a whole bunch of renames to the `units` locktime modules. These modules contain the underlying units for locktime types and hopefully aren't used directly too often, which should minimize the disruption from these renames.

  This fixes a number of issues:

  * Confusion between blocktimes and MTPs (which in fairness, *are* blocktimes, but they're not the one that users are likely to reach for)
  * Constructor and conversion names that imply there is a "consensus encoding" for these bare units, which corresponded to the consensus encoding of the corresponding locktimes/sequence numbers
  * `from_*` methods without `to_*` methods and vice-versa (overlaps with the above)
  * the horribly named `value` method on relative heights and times (but not absolute ones)

  This PR does **not** remove the `MtpAndHeight` type, nor does it add constructors for `Mtp` from lists of blocktimes. This is because the PR was too big already and I felt I should split it up.

  Alternate to #4427

ACKs for top commit:
  tcharding:
    ACK 826acb827326875f407ba0b7159894f0d8f90d2... (continued)

Coverage Stats

135 of 174 new or added lines in 7 files covered. (77.59%)

3 existing lines in 3 files now uncovered.

22983 of 27272 relevant lines covered (84.27%)

16321.11 hits per line