ParadoxGameConverters / Vic3ToHoI4 / 14812450127

93%

Build Type

push

github

Committed by web-flow

Commit Message

State regions crash (#705)

* Fix a possible crash when importing state regions.

* Make it an exception instead.

* Add test

* formatting

* More logging when reading world.

* Build fixes

* Log from CreateDefaultWorldFramework

* Remove some extraneous logging

* Fix

* Add even more logging.

* More logging in reading regions again.

* Remove async

* More logging

* Remove more async

* Try disabling province checks

* Code a check for provinces not in states.

* Run the checks

* Undo some things.

* Remove some more unneeded changes.

* Hopefully fix it.

* Remove check, lakes (and oceans?) aren't in regions.

* Remove some extra logging.

* Log repeat regions.

* Reduce logging and put in a real error.

* Add back header

Run Details

20 of 25 new or added lines in 6 files covered. (80.0%)

1 existing line in 1 file now uncovered.

20988 of 22049 relevant lines covered (95.19%)

60089.05 hits per line