tari-project / tari / 14798691696
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 707
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 73.218% (+0.08%) from 73.14%
14798691696

push

github

web-flow 
feat!: set tonic msg limits (#7016)

Description
---
Set tonic client _and server_ msg limits to 8MiB

~~**Note:** To set the corresponding limits on the server a tonic
upgrade is required as that is only supported in `tonic = "0.13.0"` and
we use `tonic = "0.12.3"`.~~

Motivation and Context
---
Block templates need to be send via grpc and we need to allow at least
6MiB (2MiB for coinbases and 4MiB for the transaction payload), whereas
the default tonic implementation limits this to 4MiB.

How Has This Been Tested?
---
Not tested - System-level testing [**TBD**].

What process can a PR reviewer use to test or verify this change?
---
- Code review.
- System-level testing.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
BREAKING CHANGE: These limits are set for the base node, wallet, merge
mining proxy and miner, but not for _external-to-main-tari-project_
applications like sha_p2pool or glytex.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added configuration to set maximum gRPC message size (8 MiB) for
wallet and base node clients, allowing handling of larger messages.

- **Refactor**
- Simplified internal logic for transaction handling in database and
validation test code, improving code clarity and consistency.
  - Enhanced test error messages for clearer diagnostics.

- **Chores**
- Updated dependencies to include a shared constant for maximum gRPC
message size.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

0 of 10 new or added lines in 1 file covered. (0.0%)

127 existing lines in 10 files now uncovered.

81553 of 111384 relevant lines covered (73.22%)

275826.39 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
10
95.01
 -1.2% base_layer/common_types/src/tari_address/dual_address.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
58.27
 1.57% base_layer/core/src/mempool/service/service.rs
1
83.98
 0.0% base_layer/core/src/transactions/transaction_key_manager/storage/sqlite_db/mod.rs
2
74.06
 -0.16% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
5
99.15
 13.79% base_layer/core/src/validation/test.rs
5
56.48
 -0.5% comms/core/src/connectivity/manager.rs
6
63.66
 -0.77% comms/dht/src/connectivity/mod.rs
7
87.14
 -0.18% comms/dht/src/config.rs
10
93.95
 0.0% comms/dht/src/dht.rs
12
72.62
 -0.55% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
78
86.66
 -0.09% comms/dht/src/actor.rs
Jobs
ID Job ID Ran Files Coverage
1 14798691696.1 707
73.22
 GitHub Action Run
Source Files on build 14798691696