rust-bitcoin / rust-bitcoin / 14798118106

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4422: units: Add regression tests for `Display` implementations

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/7bcdd5ff6655576dac79e14b9c1a50c74db310a2">7bcdd5ff6<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1aedc7e4d1344bade6cd1ff4c9a8a245379fbf6c"> Add regression tests for Display impl (Jamil Lambert, PhD)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/9c90bf49c937409af34c0a563fb198d3f3494d37">9c90bf49c</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1aedc7e4d1344bade6cd1ff4c9a8a245379fbf6c"> Add lock by time and denomination display regression tests (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/eb7dee831e2b60aaf2c5bfad02efe52d5f6f2ef8">eb7dee831</a> Rename locktime tests (Jamil Lambert, PhD)

Pull request description:

  The output of Display should not change in stable crates for types that have well defined formatting and ones that implement FromStr. Error types do not need to be tested.  Discussed in #4415.

  Patch 1 is a simple rename to allow for clearer naming when both height and time locktimes are tested.

  Patch 2 adds the missing time locktime and denomination `Display` and round trip tests to the existing macro

  Patch 3 adds all the other missing `Display` tests in `units`

ACKs for top commit:
  tcharding:
    ACK 7bcdd5ff6655576dac79e14b9c1a50c74db310a2
  apoelstra:
    ACK 7bcdd5ff6655576dac79e14b9c1a50c74db310a2; successfully ran local tests

Tree-SHA512: af8810af10812c45b71be8708a1174537c0

63 of 63 new or added lines in 2 files covered. (100.0%)

22971 of 27246 relevant lines covered (84.31%)

16357.49 hits per line