kubevirt / containerized-data-importer / #5272

59%

main: 49%

Build Type

Pull #3709

travis-ci

Committed by arnongilboa

Commit Message

Fix StorageProfile PVC rendering

When rendering a DataVolume storage-api-defined PVC:

We should not set its missing VolumeMode to any value if its specified
AccessMode has no match in the relevant StorageProfile. In this case,
fallback to k8s default (Filesysetem).

Similarly, we should not set its missing AccessModes if its specified
VolumeMode has no match in the relevant StorageProfile. In that case,
return an error as the PVC spec is incomplete.

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

Pull Request Pull Request #3709: Fix StorageProfile PVC rendering when there is no AccessMode or VolumeMode match

Run Details

5 of 7 new or added lines in 1 file covered. (71.43%)

28 existing lines in 1 file now uncovered.

16839 of 28434 relevant lines covered (59.22%)

0.65 hits per line