nlohmann / json / 14726601960

99%

push

github

fix: BJData size calculation overflow (#4765)

Adds pre-multiplication overflow detection to catch cases where dimension
products would exceed size_t max. The previous check only detected when
overflow resulted in exactly 0 or SIZE_MAX, missing other cases.

Retains the original post-multiplication check for backward compatibility.
Adds tests verifying overflow detection with dimensions (2^32+1)×(2^32),
which previously overflowed silently to 2^32.

This prevents custom SAX handlers from receiving incorrect array sizes
that could lead to buffer overflows.

Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>

1994 of 2129 branches covered (93.66%)

3 of 3 new or added lines in 1 file covered. (100.0%)

6358 of 6410 relevant lines covered (99.19%)

16535112.95 hits per line