safe-global / safe-smart-account / 14726156471

94%

push

github

Ensure Inner Simulation Reverts (#947)

This PR makes a small modification the `simulate` function such that it
ensures its inner `simulateAndRevert` reverts as expected. This is to
prevent calls to the `CompatibilityFallbackHandler` from making
unexpected state changes when not called by a Safe.

While using the `CompatibilityFallbackHandler` for something other than
a Safe fallback handler is explictely not supported, it makes sense to
ensure the inner call inverts and prevent unintended behaviours.

325 of 366 branches covered (88.8%)

Branch coverage included in aggregate %.

499 of 511 relevant lines covered (97.65%)

100.92 hits per line