• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

neo-project / neo / 14722030597
79%

Build:
DEFAULT BRANCH: master
Ran 29 Apr 2025 02:30AM UTC
Jobs 1
Files 417
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

29 Apr 2025 02:26AM UTC coverage: 79.807% (+0.06%) from 79.748%
14722030597

push

github

web-flow
Implement native Notary contract (#3178)

* Implement NotaryAssisted transaction attribute

Close #2896. Use a stub for native Notary contract hash since this
contract is not implemented yet. Thus, technically, NotaryAssisted
attribute verification will always fail on real network until native
Notary is implemented.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Payloads: add doc to CalculateNetworkFee method of NotaryAssisted attribute

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Native: add NotaryAssisted attributes handler to Gas OnPersist

Transactions network fee should be split between Primary node and Notary
nodes.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Payloads: adjust comment to NotaryAssisted attribute

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Payloads: temporary use hard-coded Notary contract hash

Once Notary contract is implemented, this hash will be replaced by a
proper Notary contract hash. The exact value won't be changed since
Notary contract has constant hash as any other native contract.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Payloads: replace hard-coded Notary hash value with calculated one

No functional changes, just a refactoring for better code readability.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Native: implement native Notary contract

Close #2897. Depends on #3175.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Native: fix typo in the exception message

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Native: use more syntactic sugar

No functional changes, just a refactoring.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Notary: add unit tests for OnNEP17Payment and ExpirationOf methods

Also, mark improper code of Withdraw method with TODO, it should be
reworked.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Fix transfer

* Update tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs

* Update UT_Notary.cs

* fix

*... (continued)

6460 of 9088 branches covered (71.08%)

Branch coverage included in aggregate %.

129 of 155 new or added lines in 2 files covered. (83.23%)

22973 of 27792 relevant lines covered (82.66%)

127551.71 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
26
76.56
src/Neo/SmartContract/Native/Notary.cs
Jobs
ID Job ID Ran Files Coverage
1 14722030597.1 29 Apr 2025 02:30AM UTC 2721
25.38
GitHub Action Run
Source Files on build 14722030597
  • Tree
  • List 417
  • Changed 323
  • Source Changed 1
  • Coverage Changed 323
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #14722030597
  • a8b1f5a4 on github
  • Prev Build on master (#14689837746)
  • Next Build on master (#14745598636)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc