rust-bitcoin / rust-bitcoin / 14717791466

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4316: Improve the script hex APIs

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/5d5a19793aae73ff09d7064455a1a995eb796c28">5d5a19793<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a9ddac178d937dce434ff4f9e8831055983a379e"> Run the formatter (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2b72f1f30bdafa234cfc6525d6e7724598d40507">2b72f1f30</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a9ddac178d937dce434ff4f9e8831055983a379e"> Make Lower/Upper hex print scripts with len prefix (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c27b95fb0dd0e5600d1f236a141bcac452306a5c">c27b95fb0</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a9ddac178d937dce434ff4f9e8831055983a379e"> Make script to/from hex use consensus encoding (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/f4bc58dc481af8198df121cdc45f2e8daafef822">f4bc58dc4</a> bitcoin: Add a script encoding example (Tobin C. Harding)

Pull request description:

  Done while investigating #3910 - this PR is quite invasive.

  - Patch 1 adds an example that shows the current behaviour of various API calls for converting scripts to/from hex.
  - Patch 2 adds a pair of functions that do not use the length prefix and makes script to/from_hex use the prefix.
  - Patch 3 makes `LowerHex` and `UpperHex` use the len prefix also
  - Patch 4 runs the formatter

  Explicitly keeps serde untouched - i.e., without the len prefix

ACKs for top commit:
  apoelstra:
    ACK 5d5a19793aae73ff09d7064455a1a995eb796c28; successfully ran local tests

Tree-SHA512: dbbec372e147e8bedfb868973e998170cb6

251 of 254 new or added lines in 9 files covered. (98.82%)

22852 of 27136 relevant lines covered (84.21%)

16419.14 hits per line