rust-bitcoin / rust-bitcoin / 14709445487

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4344: Locktime MtpAndHeight

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/8b47068a2efada30aec21c61ae4be0da4d8e8fc8">8b47068a2 feat(locktime): implement MtpAndHeight structure and validation logic (aagbotemi)

Pull request description:

  This PR fixes #4299

  - Computed MtpAndHeight structure
  - Checked if relative time and height is satisfied by MtpAndHeight
  - Compared the Ordering of MtpAndHeight with time and height
  - Checked MtpAndHeight satisfaction and comparison in Locktime
  - Added unit tests for all the implementation

  I've reviewed and adhered to the contribution guidelines

ACKs for top commit:
  apoelstra:
    ACK 8b47068a2efada30aec21c61ae4be0da4d8e8fc8; successfully ran local tests
  Kixunil:
    ACK 8b47068a2efada30aec21c61ae4be0da4d8e8fc8
  tcharding:
    ACK 8b47068a2efada30aec21c61ae4be0da4d8e8fc8

Tree-SHA512: b00d1384d87e0840781a2d10534b33097eb

Coverage Stats

136 of 137 new or added lines in 3 files covered. (99.27%)

2 existing lines in 1 file now uncovered.

22767 of 27054 relevant lines covered (84.15%)

16498.56 hits per line