Qiskit / qiskit / 14707996125

88%

Build Type

push

github

Committed by web-flow

Commit Message

Port cosine-sine decomposition to Rust. (#14233)

* [WIP] Port Cosine Sine Decomposition to Rust

This commit is the start of porting the cosine sine decomposition to
rust. Tket has a specialized implementation in their code using eigen
for the same problem space we need in qiskit for the qsd. This
commit attempts to port their implementation into Rust for qiskit so we
can have a native decomposition in rust. To start this just calls the
function via python. But this is just a short term step to validate the
implementation is correct. The eventual goal is to just replace the
python implemenation of qsd and never expose this function to Python.
This is just an intermediate steps towards working for that.

* Ensure we pass a numpy array to rust

* Finishing the implementation of the cos-sin decomposition

* more comments

* slightly decreasing the expected accuracy for TwoQubitWeylDecomposition

* Adding CSD tests

* removing unnecessary clone; slightly improving comments

* typo

* more typos/comments

* decreasing expected tolerance for test_diagonal

* undoing the change of increasing tolerance

* improve unitariness of r1; strengthen tests

* fix typos and add tests following review comments

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

Run Details

145 of 155 new or added lines in 4 files covered. (93.55%)

25 existing lines in 4 files now uncovered.

74466 of 84722 relevant lines covered (87.89%)

433815.74 hits per line