14686931002
75%

Ran 27 Apr 2025 01:50AM UTC

Jobs 1

Files 214

Run time 1min

Badge

Embed ▾

Committed 27 Apr 2025 01:18AM UTC coverage: 79.739% (-5.2%) from 84.945%

Build # 14686931002

Build Type

push

github

Committed by

dan-da

Commit Message

refactor: simplify job-queue and log unique job-id

These changes were motivated by a need to follow/debug job-queue
behavior in the logs when shared by all async unit tests.

Primary changes:
1. Each job is now assigned a randomly generated 12-byte job-id that is
   logged when adding a job and when it begins and completes
   processing.
2. Simplifies queue implementation by removing the "add_job" spawned
   task.  There is now just a single "process_job" task, and jobs are
   added to the queue, via mutex, in the caller's task.
3. The process_job task listens for a Stop message and will stop
   right away, after signaling running job to cancel, if any.
4. Adds an async stop() method that also drops the queue. It performs
   cleanup better than a simple drop().
5. improve error handling.

Squashed:

* refactor job-queue so there is only one spawned task
* separate add-job and stop into separate channels
* add job_id to jobs, log
* job-queue cleanups
* wait for current job to complete when stopping queue

Run Details

84 of 124 new or added lines in 1 file covered. (67.74%)

331 existing lines in 31 files now uncovered.

37191 of 46641 relevant lines covered (79.74%)

231785.91 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
40	88.57	-3.57%	src/job_queue/queue.rs

Uncovered Existing Lines

Lines	Coverage	∆	File
1	99.79	0.0%	src/models/blockchain/transaction/validity/tasm/single_proof/merge_branch/authenticate_coinbase_fields.rs
1	98.54	-0.03%	src/models/blockchain/transaction/validity/tasm/single_proof/update_branch.rs
2	97.59	-1.74%	src/database/storage/storage_vec/mod.rs
2	63.9	-6.07%	src/locks/tokio/atomic_mutex.rs
2	98.53	-0.3%	src/models/blockchain/transaction/validity/single_proof.rs
2	92.31	-0.67%	src/models/peer/transfer_block.rs
2	97.85	-1.21%	src/models/state/wallet/migrate_db/v0_to_v1.rs
2	95.42	-0.12%	src/util_types/test_shared/mutator_set.rs
3	99.16	-0.1%	src/models/blockchain/type_scripts/time_lock.rs
4	88.73	-4.07%	src/main_loop/proof_upgrader.rs
4	91.09	-0.34%	src/models/blockchain/block/block_height.rs
4	96.98	-0.96%	src/models/blockchain/transaction/mod.rs
6	67.68	-6.78%	src/main_loop.rs
6	94.22	9.48%	src/models/blockchain/block/mod.rs
6	98.58	-0.17%	src/models/blockchain/block/validity/block_program.rs
7	95.68	-0.08%	src/models/blockchain/transaction/primitive_witness.rs
7	94.55	-4.52%	src/models/state/wallet/mod.rs
8	82.89	-10.17%	src/connect_to_peers.rs
9	56.25	-42.26%	src/database/storage/storage_schema/mod.rs
9	77.29	-8.03%	src/rpc_auth.rs
9	87.76	-3.11%	src/util_types/mutator_set/mutator_set_accumulator.rs
11	98.19	-0.05%	src/models/blockchain/type_scripts/native_currency.rs
13	95.92	-0.57%	src/util_types/mutator_set.rs
20	89.59	-5.76%	src/models/state/mempool.rs
21	76.23	-9.04%	src/rpc_server.rs
22	91.21	-3.95%	src/models/state/wallet/wallet_state.rs
25	50.42	-13.15%	src/mine_loop.rs
29	89.24	-7.89%	src/models/state/archival_state.rs
29	68.16	-18.53%	src/peer_loop.rs
32	83.84	-8.91%	src/models/state/mod.rs
33	86.15	-1.61%	src/models/proof_abstractions/tasm/program.rs

Jobs

ID	Job ID	Ran	Files	Coverage
1	14686931002.1	27 Apr 2025 01:50AM UTC	214	79.74	GitHub Action Run

Neptune-Crypto / neptune-core / 14686931002
75%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 14686931002

Neptune-Crypto / neptune-core / 14686931002 75%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 14686931002

Neptune-Crypto / neptune-core / 14686931002
75%

README BADGES
x