rust-bitcoin / rust-bitcoin / 14647663368

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4250: Introduce and use `test_hex_unwrap` macro in `internals`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/d6296cd3d1989cf28d67a5329ad60da4f814ba92">d6296cd3d<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5f4075a0719a7a60ac9cd74da717cc176c1e2efd"> Remove usage of hex::test_hex_unwrap (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/37035e20e8abd253ddd027fe283054fe63df6014">37035e20e</a> Simplify and improve transaction benchmarks (Tobin C. Harding)

Pull request description:

  We have the `hex_lit` dependency for converting a hex string literal to an array.

  Currently we have a `test_hex_unwrap` macro in the `hex v0.3.0` release but not on either `master`
  or the upcoming `v1.0.0-alpha.0` release. This is making PRs around releasing and depending on the
  release more noisy than required.

  Introduce a `test_hex_unwrap` macro in internals for usage when the input is not a string literal.

  Use `hex_lit::hex` where possible (often needing an additional call to

ACKs for top commit:
  apoelstra:
    ACK d6296cd3d1989cf28d67a5329ad60da4f814ba92; successfully ran local tests
  Kixunil:
    ACK d6296cd3d1989cf28d67a5329ad60da4f814ba92

Tree-SHA512: eab3573f6540bdc31e709367e619d4d4054

Coverage Stats

45 of 45 new or added lines in 8 files covered. (100.0%)

1 existing line in 1 file now uncovered.

22619 of 26901 relevant lines covered (84.08%)

16569.8 hits per line