• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Qiskit / qiskit / 14640289610
88%

Build:
DEFAULT BRANCH: main
Ran 24 Apr 2025 11:42AM UTC
Jobs 1
Files 802
Run time 22min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

24 Apr 2025 10:36AM UTC coverage: 87.931% (+0.04%) from 87.896%
14640289610

push

github

web-flow
Add custom `Qargs` implementation for `Target` (#14210)

* Initial: Add custom `Qargs` implementation for `Target`.

A custom implementation of `Qargs` was added to `Target` allowing us to directly fix an ownership issue that was currently being solved by `NullableIndexMap`. These additions will ensure the following:
- Seamless conversion from Python `tuple[int]` and Rust `SmallVec<[PhysicalQubit; 2]>`.
- Usage of `Option<&[PhysicalQubit]>` as a valid query for the `Target`.

* Refactor: `TargetQargs` is now `Qargs`.
- `TargetQargsRef` is now `QargsRef`.

* Fix: Use generics for querying into the `Target`.
 Use a `pub use` to export `Qargs`, and `QargsRef` directly from the `target_transpiler` module.
 - Add additional conversion to `&Qargs` to `PyTuple`.
 - Add `From<[T; N]>` for `Qargs` and `QargsRef`.
 - Enable use of generics to query into the `Qargs` present in `Target`. These are based on `Into<QargRef>` and include `&Qarg`, `&[PhysicalQubit]` and others.

* Fix: Make `Qargs` and `QargsRef` more lean
- Remove unnecessary methods from `Qargs` as pointed out by @jakelishman.
- Remove macro derives `Default`, `Ord`, and `PartialOrd` as they had incorrect semantic implications.
- Added more generic `From` and `FromIterator` implementations to make usage more versatile.

* Fix: `update_instruction_properties` signature.

* Fix: update signatures for `for_qargs` methods.

* Refactor: Remove wrongful use of underscore prefixed names.
- Fix docstrings documenting `Qargs` as `TargetQargs`.

* Fix: Address review comments
- `extract_target_basis` uses `SmallVec` instead of `Qargs`.
- Use`let Some(val) = conscript else { // }` pattern.
- Fix docstring for `py_qargs_for_operation_name`.
- Move `pub use` of qargs to top of document.

* Docs: Remove stray comment

223 of 280 new or added lines in 11 files covered. (79.64%)

5 existing lines in 3 files now uncovered.

74142 of 84318 relevant lines covered (87.93%)

435209.34 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
94.78
-0.02% crates/accelerate/src/unitary_synthesis.rs
2
83.11
-0.31% crates/accelerate/src/vf2_layout.rs
6
88.99
-0.49% crates/accelerate/src/basis/basis_translator/mod.rs
17
71.19
crates/accelerate/src/target_transpiler/qargs.rs
31
79.11
0.48% crates/accelerate/src/target_transpiler/mod.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
94.78
-0.02% crates/accelerate/src/unitary_synthesis.rs
1
94.23
-0.23% crates/qasm2/src/expr.rs
3
91.98
-0.25% crates/qasm2/src/lex.rs
Jobs
ID Job ID Ran Files Coverage
1 14640289610.1 24 Apr 2025 11:42AM UTC 802
87.93
GitHub Action Run
Source Files on build 14640289610
  • Tree
  • List 802
  • Changed 12
  • Source Changed 10
  • Coverage Changed 11
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #14640289610
  • 2270951e on github
  • Prev Build on main (#14637349697)
  • Next Build on main (#14663307542)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc