Qiskit / qiskit / 14640289610

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add custom `Qargs` implementation for `Target` (#14210)

* Initial: Add custom `Qargs` implementation for `Target`.

A custom implementation of `Qargs` was added to `Target` allowing us to directly fix an ownership issue that was currently being solved by `NullableIndexMap`. These additions will ensure the following:
- Seamless conversion from Python `tuple[int]` and Rust `SmallVec<[PhysicalQubit; 2]>`.
- Usage of `Option<&[PhysicalQubit]>` as a valid query for the `Target`.

* Refactor: `TargetQargs` is now `Qargs`.
- `TargetQargsRef` is now `QargsRef`.

* Fix: Use generics for querying into the `Target`.
 Use a `pub use` to export `Qargs`, and `QargsRef` directly from the `target_transpiler` module.
 - Add additional conversion to `&Qargs` to `PyTuple`.
 - Add `From<[T; N]>` for `Qargs` and `QargsRef`.
 - Enable use of generics to query into the `Qargs` present in `Target`. These are based on `Into<QargRef>` and include `&Qarg`, `&[PhysicalQubit]` and others.

* Fix: Make `Qargs` and `QargsRef` more lean
- Remove unnecessary methods from `Qargs` as pointed out by @jakelishman.
- Remove macro derives `Default`, `Ord`, and `PartialOrd` as they had incorrect semantic implications.
- Added more generic `From` and `FromIterator` implementations to make usage more versatile.

* Fix: `update_instruction_properties` signature.

* Fix: update signatures for `for_qargs` methods.

* Refactor: Remove wrongful use of underscore prefixed names.
- Fix docstrings documenting `Qargs` as `TargetQargs`.

* Fix: Address review comments
- `extract_target_basis` uses `SmallVec` instead of `Qargs`.
- Use`let Some(val) = conscript else { // }` pattern.
- Fix docstring for `py_qargs_for_operation_name`.
- Move `pub use` of qargs to top of document.

* Docs: Remove stray comment

Run Details

223 of 280 new or added lines in 11 files covered. (79.64%)

5 existing lines in 3 files now uncovered.

74142 of 84318 relevant lines covered (87.93%)

435209.34 hits per line