kubevirt / containerized-data-importer / #5247

49%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

include error message for upload failure due to lack of space (#3704)

The uploadserver features two handler functions for sync and async
uploads.

The async upload handler correctly reports an error message if QEMU
image size validation errors due to lack of space in the target by
appending the error message to the HTTP response. The sync upload
handler, however, does not.

This commit makes error handling for failed upload identical between
both handlers. Furthermore, it also checks for ENOSPC errors during
write as can happen when the image is streamed directly into target
instead of going through scratch space first (e.g., raw images). It also
consolidates the sync and async upload failure e2e tests into a single
DescribeTable and improves upon its clarity.

Signed-off-by: Adi Aloni <aaloni@redhat.com>

Run Details

12 of 16 new or added lines in 1 file covered. (75.0%)

2 existing lines in 1 file now uncovered.

16815 of 28417 relevant lines covered (59.17%)

0.65 hits per line