xapi-project / xen-api / 14618010995
80%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 33
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 77.719%. Remained the same
14618010995

push

github

web-flow 
CA-409628: fix error-prone Debug.log_backtrace that always lost the important part of the backtrace (#6430)

Before/after can be seen clearly in the newly added unit test:
* previously line 8 was not printed anywhere, even though that is the
actual place the exception is raised
* the whole backtrace was printed on a single line, which can be quite
annoying

After:
* line 8 is present
* the correct backtrace printer is used that prints each stack frame on
a separate line with a counter

```diff --git a/ocaml/libs/log/test/log_test.t b/ocaml/libs/log/test/log_test.t
index f25ee7057..fbdeebfed 100644
--- a/ocaml/libs/log/test/log_test.t
+++ b/ocaml/libs/log/test/log_test.t
@@ -1,4 +1,9 @@
   $ ./log_test.exe | sed -re 's/[0-9]+T[0-9:.]+Z//'
-  [|debug||0 |main|log_test.ml] Raised at Xapi_stdext_pervasives__Pervasiveext.finally in file \"ocaml/libs/xapi-stdext/lib/xapi-stdext-pervasives/pervasiveext.ml\", line 39, characters 6-15\nCalled from Dune__exe__Log_test.(fun) in file \"ocaml/libs/log/test/log_test.ml\", line 15, characters 4-55\n
+  [|error||0 |main|backtrace] Raised Invalid_argument("index out of bounds")
+  [|error||0 |main|backtrace] 1/4 log_test.exe Raised at file ocaml/libs/log/test/log_test.ml, line 8
+  [|error||0 |main|backtrace] 2/4 log_test.exe Called from file ocaml/libs/xapi-stdext/lib/xapi-stdext-pervasives/pervasiveext.ml, line 24
+  [|error||0 |main|backtrace] 3/4 log_test.exe Called from file ocaml/libs/xapi-stdext/lib/xapi-stdext-pervasives/pervasiveext.ml, line 39
+  [|error||0 |main|backtrace] 4/4 log_test.exe Called from file ocaml/libs/log/test/log_test.ml, line 15
+  [|error||0 |main|backtrace]
```

3359 of 4322 relevant lines covered (77.72%)

0.78 hits per line

Jobs
ID Job ID Ran Files Coverage
1 python3.11 - 14618010995.1 33
77.72
 GitHub Action Run
Source Files on build 14618010995