nats-io / nats.js / 14579522670

86%

Build Type

push

github

Committed by web-flow

Commit Message

feat(js): expose pedantic option on consumer create (#275)

* Refactor ConsumerAPI to separate add and update logic

Inadvertently exposed ConsumerApiOptions, which at this time should only expose the `pedantic` option. Refactored the type to be backward compatible in case someone is already using it even though it has not not been released.

Introduced `addUpdate` method to handle shared logic for consumer creation and updates, while keeping `add` and `update` methods for specific actions. This enhances code clarity and maintains backward compatibility by adapting argument handling in the `add` method.

Signed-off-by: Alberto Ricart <alberto@synadia.com>

* Update types to use ConsumerCreateOptions in consumer methods

Replaced ConsumerApiOptions with ConsumerCreateOptions in the consumer addition method for better specificity and alignment. Updated related imports across the module to support the change. This ensures improved type handling and consistency in consumer creation workflows.

Signed-off-by: Alberto Ricart <alberto@synadia.com>

---------

Signed-off-by: Alberto Ricart <alberto@synadia.com>

Run Details

2385 of 3241 branches covered (73.59%)

Branch coverage included in aggregate %.

13 of 21 new or added lines in 1 file covered. (61.9%)

5 existing lines in 1 file now uncovered.

10279 of 11738 relevant lines covered (87.57%)

761578.92 hits per line