NZOI / nztrain / 14556569562

38%

Build Type

push

github

Committed by web-flow

Commit Message

Remove caching from controller permitted_params etc. (#289)

We don't call these methods multiple times during a single request, so
there is no point in caching the result. (The example from the
original strong_parameters gem doesn't use caching:
https://github.com/rails/strong_parameters.)

This also eliminates silly inconsistencies with what was cached -- in
some places it was @_permitted_params, while in other places it was
the intermediate @_permitted_attributes.

Also remove method `visible_attributes` from user_controller.rb, it's
unused since commit 8798951a (Refactor to remove the UserPresenter
service object (#165), 2023-02-18).

Run Details

32 of 51 new or added lines in 16 files covered. (62.75%)

4 existing lines in 4 files now uncovered.

2241 of 5986 relevant lines covered (37.44%)

5.66 hits per line