basilisp-lang / basilisp / 14551910947

99%

push

github

Make support for single-use iterables explicit (#1235)

Hi, 

could you please consider patch to remove explicit support of single-use
iterables in sequences. It fixes #1192.

single-use iterables now throw a `TypeError`, when they are implicitly
or explicitly coerced into a sequence. A new `iterator-seq` is
introduced to explicitly convert them into a seq instead . See
https://github.com/basilisp-lang/basilisp/pull/1198#issuecomment-2810302395
for the rationale.

The `count` fn was also updated to behave the same.

There were a few places where single use iterators were converted
implicitly to a seq, which are now explicitly converted using a
`iterator-seq` or the python equivalent instead.

Tests are added for the same, as well as documentation section under
Python Iterators.

Thanks

---------

Co-authored-by: ikappaki <ikappaki@users.noreply.github.com>

1047 of 1056 branches covered (99.15%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 4 files covered. (100.0%)

8925 of 9050 relevant lines covered (98.62%)

0.99 hits per line