rust-bitcoin
/
rust-bitcoin
/
14536619160
83%
|
Ran
|
Jobs
1
|
Files
130
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 84.031% (-0.05%) from 84.08%
push
github
apoelstraMerge rust-bitcoin/rust-bitcoin#4322: fix: enforce standard minimal push for push_slice <a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/354e1e42ad98c7968827d03be563bc14d764a983">354e1e42a<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c85648cfd40962338285fa29f9682e3bcd0caf8f"> fix: enforce minimal push for push_slice (ChrisCho-H) Pull request description: Currently `push_slice` doesn't check the standard minimal push rule, which could result in possible money loss(e.g. if non minimal push is used in output script of p2wsh or p2tr). Introduce `push_slice_non_minimal` to provide the way to push as now, and change `push_slice` logic to follow standard minimal push rule. https://github.com/bitcoin/bitcoin/blob/<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/99a4ddf5ab1b3e514d08b90ad8565827fda7b63b">99a4ddf5a</a>/src/script/script.cpp#L366 ACKs for top commit: tcharding: ACK 354e1e42ad98c7968827d03be563bc14d764a983 apoelstra: ACK 354e1e42ad98c7968827d03be563bc14d764a983; successfully ran local tests Tree-SHA512: 01f53dbd26054503a3ac37a111d6ba46f57
17 of 28 new or added lines in 2 files covered. (60.71%)
6 existing lines in 1 file now uncovered.22559 of 26846 relevant lines covered (84.03%)
16582.88 hits per line
Uncovered Changes
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 6 |
71.23 |
-3.34% | bitcoin/src/blockdata/script/builder.rs |
| 5 |
72.81 |
-1.95% | bitcoin/src/blockdata/script/owned.rs |
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 6 |
85.9 |
-0.37% | bitcoin/src/psbt/mod.rs |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 14536619160.1 | 130 |
84.03 |
GitHub Action Run |
