Qiskit / qiskit / 14525693623

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add new API for inserting multiple operations into the `DAGCircuit` in Rust. (#13335)

* Initial: Add `DAGCircuitConcat` struct and new insertion API.
- Add struct that allows continuous addition of instructions into the back of the `DAGCircuit` by performing edge modifications in the output nodes at the end of the additions.
- The new struct includes the following new methods:
    - `push_operation_back` which pushes a valid `PackedInstruction` into the back of the `DAGCircuit`. It behaves very similarly to `push_back`.
    - `apply_operation_back` which inserts a new operation into the back of the `DAGCircuit`. It has two variants which depend on the ownership of the bit indices (`Qubit`, `Clbit`).
    - `pack_instruction`: private method that basically does just that, it creates a valid instance of `PackedInstruction` based on other provided atributes.
- Modified `DAGCircuit::extend` to use this new API, without any considerable losses.

* Add: `OwnedOrSlice<T>`
- Add struct that allows usage of both slice or owned collections of bit indices.
- Leverage use of `as_concat()` in `circuit_to_dag`.

* Add: Optional qargs/cargs in `apply_operation_back`
- Leverage usage of new methods in `UnitarySynthesis` after #13141 merged.

* Fix: Leverage usage in `BasisTranslator`

* Fix: Replace `OnceCell` with `OnceLock`

* Fix: Remove `SliceOrOwned` in favor of `Cow`

* Fix: Expose the interners via references within `DAGCircuitConcat`.

* Refactor: `DAGCircuit::as_concat` to `DAGCircuit::into_concat`.
- Allow `DAGCircuitConcat` to take ownership of the original `DAGCircuit` it is being called from, and allow `DAGCircuitConcat::end` to return the original `DAGCircuit`.
- Bypass taking ownership of the `DAGCircuit` during `DAGCircuit::extend` calls by swapping with a temporary replacement.

* Fix: Remove inefficient code from `UnitarySynthesis`
- A previous commit added some inefficient code into the `apply_synth_dag` function in `UnitarySynthesis`. The newer co... (continued)

Run Details

281 of 283 new or added lines in 3 files covered. (99.29%)

5 existing lines in 2 files now uncovered.

73818 of 83632 relevant lines covered (88.27%)

440297.22 hits per line