• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

vispy / vispy / 14515543648
75%

Build:
DEFAULT BRANCH: main
Ran 17 Apr 2025 12:26PM UTC
Jobs 4
Files 345
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

17 Apr 2025 12:23PM UTC coverage: 74.916% (+0.01%) from 74.905%
14515543648

push

github

web-flow
Various optimizations related to camera linking and mesh normals (#2532)

See #2530 

CC @jintaoLee-roger

This is a collection of optimizations uncovered in #2530 debugging by me
or @jintaolee-roger. The main ideas are to not update camera properties
unless the value has actually changed. This prevents expensive
transform-updating methods from being called unnecessarily. This is
especially noticeable when a single camera move updates 4+ properties of
a linked property and each one tries to report that the view/transform
has changed. It does this in two ways:

1. Don't execute a transform update if we're updating properties
2. Don't update a property (and signal a view change) if the property
value is the same

This PR also adds some checks in the mesh light filter to see if vertex
normals have actually changed before submitting/uploading the normals to
the GPU. It also enables the use of a previously unused (yet defined for
some reason?) `MeshData._vertex_normal_indexed_by_faces`. This allows
the check in the light filter to actually work with a simple identity
(`is`) check.


TODO:

* Testing of performance by @jintaolee-roger
* Adding tests for at least the normals caching in the meshdata.

---------

Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>

5871 of 10611 branches covered (55.33%)

60 of 68 new or added lines in 6 files covered. (88.24%)

2 existing lines in 1 file now uncovered.

24179 of 32275 relevant lines covered (74.92%)

2.45 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
66.67
-0.23% vispy/scene/cameras/panzoom.py
1
65.75
0.4% vispy/scene/cameras/perspective.py
6
85.82
0.28% vispy/scene/cameras/base_camera.py

Uncovered Existing Lines

Lines Coverage ∆ File
2
70.89
1.32% vispy/scene/cameras/turntable.py
Jobs
ID Job ID Ran Files Coverage
1 run-4 - 14515543648.1 17 Apr 2025 12:37PM UTC 345
72.48
2 run-1 - 14515543648.2 17 Apr 2025 12:37PM UTC 345
46.69
3 run-3 - 14515543648.3 17 Apr 2025 12:37PM UTC 345
52.01
4 run-2 - 14515543648.4 17 Apr 2025 12:37PM UTC 345
74.17
Source Files on build 14515543648
  • Tree
  • List 345
  • Changed 6
  • Source Changed 0
  • Coverage Changed 6
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • cff17d30 on github
  • Prev Build on main (#14510827620)
  • Next Build on main (#14592641548)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc