expressjs / compression / 14498812440

100%

master: 100%

push

github

Do not swallow calls to `res.end()` (#188)

* Add tests demonstrating scenarios under which the original res.end does not get called

* Ensure stream gets closed and response gets ended when it is finished

* Only call the original res.end() a single time

* Avoid using the on-finished package

* Use finished() helper from node:stream

* Import finished() helper directly from node:stream

Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com>

* Use finished() helper directly instead of nodeStream.finished()

* Adjust stream pause / resume logic instead of messing with res.end() calls directly

* Revert addition of endOnce() wrapper

* Add unit test around one more alternate sequence of events that seems reasonable to test in addition to the other ones

* Add test around avoiding 'write after end' errors

* Avoid writing into the response after it is finished

* Add a comment explaining why the compression stream gets resumed when the response finishes

* chore: use isFinished of on-finished

---------

Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com>

8 of 8 new or added lines in 1 file covered. (100.0%)

115 of 115 relevant lines covered (100.0%)

770.82 hits per line