kubevirt / hyperconverged-cluster-operator / 14485009561

76%

push

github

Check descheduler according to new profile (#3476)

* Check descheduler according to new profile

On the descheduler we now have a KubeVirt
dedicated profile named KubeVirtRelieveAndMigrate.
Enforce its presence if the descheduler is in use.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

* Move the KubeDescheduler validation to the controller

The clusterInfo interface's  `IsDeschedulerMisconfigured()` and
`RefreshDeschedulerCR()` functions are only called from the controller,
and should not be globally available. Also, the current logic is using a
cache mechanism that is never actually used, becase the user call always
calls `RefreshDeschedulerCR()` (to refresh the cache) before calling to
`IsDeschedulerMisconfigured()` (to read the cache). So the cache saves
nothing.

In addition, the ClusterInfo is huge: it contains 21 functions, while
golang best practice is to write interfaces as smaller as possible. It
is hard to implement and maintain such a big interface, where any change
in any function, need to be implemented in all the implementations.

This commit moves the KubeDescheduler validation logic from the
ClusterInfo, to the descheduler controller, where it actually been used,
to get more effective, more readable code, and to reduce the number of
functions in the ClusterInfo interface.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Align e2e tests

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

---------

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Co-authored-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

16 of 27 new or added lines in 2 files covered. (59.26%)

6536 of 9026 relevant lines covered (72.41%)

0.95 hits per line