zhmcclient / zhmc-ansible-modules / test-2643

44%

Build Type

push

github

Committed by andy-maier

Commit Message

Added expand_names and fixes for zhmc_user, zhmc_user_list

Details:

* Added a boolean 'expand_names' parameter to the 'zhmc_user' module. This
  allows disabling the addition of names for referenced objects. For
  backwards compatibility, this parameter is True by default.

* Added a boolean 'expand_names' parameter to the 'zhmc_user_list' module. This
  allows enabling the addition of names for referenced objects, which improves
  the performance compared to a loop of calls to the 'zhmc_user' module
  with 'expand_names', because the data needed for translating the URIs to names
  is retrieved only once. To save these extra retrieval operations by default,
  this parameter is False by default.

* Added support for the following properties and input parameters in the
  'zhmc_user' and 'zhmc_user_list' modules:
  - user-template related
  - primary-mfa-server-definition related
  - backup-mfa-server-definition related
  - default-group related

* Added a logged warning if the deprecated parameter 'expand' is used for
  the 'zhmc_user' module.

* Test: For the password-rule related properties of the 'zhmc_user' and
  'zhmc_user_list' modules, fixed that they are always present, and not
  dependent on auth-type=local.

* Test: For the ldap-server-definition related properties of the 'zhmc_user' and
  'zhmc_user_list' modules, fixed that they are always present, and not
  dependent on auth-type=local.

* Test: For the MFA related properties of the 'zhmc_user' and
  'zhmc_user_list' modules, fixed that they are always present, and not
  dependent on mfa-types or other MFA related properties.

* Docs: In the parameter documentation for the 'zhmc_user' and 'zhmc_user_list'
  modules, made the language more explicit that states under which conditions
  each parameter is present.

* Test: Removed the invalid combinations of type and auth-type from the end2end
  test 'test_zhmc_user_facts()'.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>

Run Details

45 of 201 new or added lines in 3 files covered. (22.39%)

2 existing lines in 1 file now uncovered.

2651 of 6277 relevant lines covered (42.23%)

5.48 hits per line