bolshakov / stoplight / 14419258696

100%

push

github

Optimize notification locking for improved responsiveness (#293)

The original implementation of `#with_deduplicated_notification` in `Memory` data store was locking the
entire data store via MonitorMixin's `synchronize` while yielding to notifiers. Even though notifications
are rare in our system, when they do happen, they could potentially block other critical operations.

This change introduces a focused optimization:

1. Separate the notification lock from the main data store lock by using a dedicated `Thread::Mutex` specifically for notifications
2. Move the yield operation outside of the synchronized block to prevent blocking other operations during notification processing
3. Add benchmarks to measure and verify the performance characteristics

Under simulated high contention (10 resource names, 16 threads with 0.001s operations):
- Original implementation: ~36.7s real time
- Optimized implementation: ~2.8s real time (13x faster)

Even under low contention scenarios, which better represent our production environment, the optimized version showed similar improvements in responsiveness.

While notifications are infrequent in our system, the impact of blocking the entire data store during a
notification can still affect system responsiveness. This change ensures that when notifications do occur,
they don't interfere with other critical operations that might be happening simultaneously.

The optimization maintains the same semantics and thread safety guarantees while significantly reducing
the potential for lock contention during these occasional but important notification events.

5 of 5 new or added lines in 1 file covered. (100.0%)

427 of 427 relevant lines covered (100.0%)

252.34 hits per line