vispy / vispy / 14401696871

75%

push

github

Ignore unhandled Qt events (#2600)

Currently, the Qt backend eats all events, regardless of whether vispy
actually acts upon them. In my judgement, this seems contrary to the
"best practices" of Qt, where events should be passed along if they are
not acted upon.

This changeset calls
[`QEvent.ignore()`](https://doc.qt.io/qt-6/qevent.html#ignore) in all of
the relevant locations I could find (if there are some I missed, we
should probably add this code there too), allowing parent widgets the
chance to respond to unhandled events.

I'm wary about this change introducing other bugs, specifically in
parent Qt widgets who are now receiving events they were not expecting -
this changeset is likely a tradeoff that I think is worth consideration.

I'm not terribly sure whether this changeset warrants any changes to
test code, and/or where those changes would be. If you'd like me to
write tests, I'm happy to do so, I'd just appreciate a little direction
on where to start!

5818 of 10550 branches covered (55.15%)

0 of 28 new or added lines in 1 file covered. (0.0%)

24050 of 32154 relevant lines covered (74.8%)

2.45 hits per line