14384818421
88%

Ran 10 Apr 2025 04:05PM UTC

Jobs 1

Files 518

Run time 2min

Badge

Embed ▾

Committed 10 Apr 2025 03:50PM UTC coverage: 87.482% (-0.01%) from 87.495%

Build # 14384818421

Build Type

push

github

Committed by

sergepetrenko

Commit Message

box: fix session use-after-free

If session is created on demand in fiber we delete it when fiber is
stopped. But we do not clear session and credentials in fiber storage.
It is not an issue for standalone fiber (outside of fiber pool) as fiber
will be destroyed or recycled and will not have chance to execute any
code before that. In case of fiber pool it become dangerous as fiber is
reused. Fortunately we never hit this because we either reset session
and credentials at start in code executed in fiber (like in iproto) or
execute code that does not check access (like in vinyl).

Recently we add `tnt_tx_push()` to execute callback in TX. This time
the issue is revealed.

Let's just clear session and credentials in fiber storage when fiber
is stopped.

Closes #11267

NO_DOC=bugfix

Run Details

70295 of 123997 branches covered (56.69%)

2 of 2 new or added lines in 1 file covered. (100.0%)

49 existing lines in 18 files now uncovered.

103435 of 118236 relevant lines covered (87.48%)

2973617.07 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	90.7	-0.07%	src/box/applier.cc
1	88.55	-0.6%	src/box/engine.c
1	95.31	-1.56%	src/box/engine.h
1	90.14	-0.08%	src/box/vy_log.c
1	94.99	-0.21%	src/box/vy_read_iterator.c
1	90.9	-0.1%	src/box/vy_scheduler.c
1	96.15	-0.05%	src/lib/salad/bps_tree.h
1	91.68	-0.11%	src/lib/swim/swim.c
2	95.96	-0.36%	src/box/relay.cc
2	89.24	-0.11%	src/box/xrow.c
2	85.13	-0.27%	src/lib/core/say.c
2	94.22	-0.39%	src/lua/fiber.c
3	92.45	-0.04%	src/box/vinyl.c
3	22.66	-0.04%	src/lib/uri/uri_parser.c
4	90.85	-0.13%	src/box/box.cc
4	94.25	-0.78%	src/box/xrow_update_field.c
4	93.31	-1.27%	src/lib/swim/swim_io.c
15	91.95	-2.32%	src/box/memtx_space.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	14384818421.1	10 Apr 2025 04:05PM UTC	518	87.48	GitHub Action Run

tarantool / tarantool / 14384818421
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 14384818421

tarantool / tarantool / 14384818421 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 14384818421

tarantool / tarantool / 14384818421
88%

README BADGES
x