rust-bitcoin / rust-bitcoin / 14382779490
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 130
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.606% (-0.02%) from 83.63%
14382779490

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#4312: units: Return `NumOpResult` when implementing `Div`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/d6881ff5f861b8a85883ec88ce453cc02191ba14">d6881ff5f<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d222fdd8792c572fdb8eb7c6cba5045429aacc0c"> units: Enable differentiating div-by-zero (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5fb64953c55cc22120471b5a02f6be4a0a2b9415">5fb64953c</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d222fdd8792c572fdb8eb7c6cba5045429aacc0c"> units: Return NumOpResult when implementing Div (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/dba61c9efecc9c8ce9dd04d4def957a3cf49ad27">dba61c9ef</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d222fdd8792c572fdb8eb7c6cba5045429aacc0c"> units: Fix internal docs (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/512326b8b997cbdfbbf9746252a2a52264a139f8">512326b8b</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d222fdd8792c572fdb8eb7c6cba5045429aacc0c"> units: Macroize implementing OptionExt (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/f5b54e5fe065181081cfb68c6e9ef09528498e9e">f5b54e5fe units: Move general result stuff to a separate module (Tobin C. Harding)
f49efdf3f units: Remove mention of amount in result module (Tobin C. Harding)

Pull request description:

  First 4 patches are preparatory clean up. Patch 5 and 6 make all implementations of `Div` in the crate return `NumOpResult`. Done as two separate patches to assist review and in case we need to iterate, patch 5 is likely trivial to review.

  Fix: #4215

ACKs for top commit:
  apoelstra:
    ACK d6881ff5f861b8a85883ec88ce453cc02191ba14; successfully ran local tests

Tree-SHA512: 7188262dbf364419d8298a70b696ab358a1

51 of 87 new or added lines in 4 files covered. (58.62%)

22241 of 26602 relevant lines covered (83.61%)

16760.45 hits per line

Uncovered Changes

Lines Coverage ∆ File
32
48.39
 units/src/result.rs
4
90.57
 16.28% units/src/amount/result.rs
Jobs
ID Job ID Ran Files Coverage
1 14382779490.1 130
83.61
 GitHub Action Run
Source Files on build 14382779490