bolshakov / stoplight / 14374828186

100%

push

github

Drop Redlock gem in favor of notification deduplication mechanism (#284)

- Renamed `with_notification_lock` to `with_deduplicated_notification` to accurately reflect its purpose
- Implemented a Redis-based notification deduplication system using Lua scripting

The previous approach attempted to use a locking mechanism, but what we actually needed was notification deduplication. This change:
- Eliminates unnecessary complexity and dependencies
- More precisely addresses the actual problem: preventing duplicate notifications
- Provides better performance by using atomic Lua operations

This PR introduces a backward incompatible change to the `Stoplight::DataStore::Base` interface:
`with_notification_lock` was renamed to `with_deduplicated_notification`

- Developers who have created custom data store implementations that inherit from `Stoplight::DataStore::Base`
- Users who directly call the `with_notification_lock` method

Custom data store implementations should rename their method from `with_notification_lock` to `with_deduplicated_notification` and
update implementation to match the new signature.

15 of 15 new or added lines in 4 files covered. (100.0%)

423 of 423 relevant lines covered (100.0%)

250.09 hits per line