RobinTail / express-zod-api / 14359023797

100%

push

github

Aligning catcher with documentation (#2525)

Removing the status code coercion to `400` in the catcher, so that
errors other than `HttpError` lead to `500` response by default.
Found the discrepancy from the documented behaviour on error handling.
Most likely introduced in v19.0.0 by #1741 

Pick from the documentation

> - Ones related to routing, parsing and upload issues — handled by
`ResultHandler` assigned to `errorHandler` in config:
> - Default is `defaultResultHandler` — it sets the response status code
from the corresponding `HttpError`:
> `400` for parsing ⚠️ 👀 **(this should be corrected to what specific
parser throws)**, `404` for routing ✅ ,
`config.upload.limitError.statusCode` for upload issues ✅ , or `500` for
others ⚠️ **(this one was 400 in catcher, fixed below)**;

1279 of 1304 branches covered (98.08%)

2 of 2 new or added lines in 1 file covered. (100.0%)

4252 of 4252 relevant lines covered (100.0%)

218.43 hits per line