openbraininstitute / neurodamus / 14358729511

90%

Build Type

push

github

Committed by web-flow

Commit Message

Gap junctions: new unit tests and remove legacy code (#183)

## Context
For #169 #186 , this PR adds unit tests for gap junctions including user
corrections (Oren's script), and meanwhile removes the legacy code.

## Scope
1. Ring test circuit: add the node population C, and C->C chemical and
electrical edges. A new `circuit_config_gj.json` includes this
population.
2. `tests/unit/test_gapjunction.py`: new unit tests for gap junction
including user corrections.
3. Code cleanup: remove legacy about reading `gjinfo.txt` for gj
offsets, rename gj synapse parameters, remove `configure_cell` as gj
connections don't configure synapses.
4. `gj_user_corrections.py`: rename to
`gap_junction_user_corrections.py`

## Testing
`tests/unit/test_gapjunction.py`

## Review
* [x] PR description is complete
* [x] Coding style (imports, function length, New functions, classes or
files) are good
* [x] Unit/Scientific test added
* [ ] Updated Readme, in-code, developer documentation

Run Details

8 of 67 new or added lines in 4 files covered. (11.94%)

2 existing lines in 2 files now uncovered.

6735 of 8955 relevant lines covered (75.21%)

0.99 hits per line