unicode-org / icu4x / 14356886037

73%

Build Type

push

github

Committed by web-flow

Commit Message

Parse system locales in `env_preferences` (#6158)

As per the discussion in #6028, I have created a POSIX locale
parser/converter, currently hidden in the private
`env_preferences::parse` module. This is meant to change at some point
while the PR is being drafted, especially once I add support for other
platforms. Once more platforms are supported, I would also like to
implement universal and platform-specific APIs, as per [this
comment](https://github.com/unicode-org/icu4x/discussions/6028#discussioncomment-12037139)
by @zbraniecki.

My current thinking on code structure is to have some distinction
between platform `fetch` and `parse` code (either using modules or
files), but please let me know if all platform logic should just be kept
in the same file.

Of course, feedback on the code itself would be very much appreciated!

---------

Co-authored-by: Robert Bastian <robertbastian@unicode.org>

Run Details

171 of 223 new or added lines in 7 files covered. (76.68%)

3 existing lines in 3 files now uncovered.

57993 of 79379 relevant lines covered (73.06%)

811462.64 hits per line