kubevirt / containerized-data-importer / #5219

59%

main: 49%

Build Type

Pull #3692

travis-ci

Committed by Acedus

Commit Message

Fix cdi-deployment Deployment selector

The cdi-deployment selector has a matchLabels value of {"app":
"containerized-data-importer"} which is a common label that appears on
many CDI related Pods (e.g., cdi-apiserver, cdi-uploadproxy, importer,
etc.).

This causes certain functionalities such as the log subresource to
misbehave as it targets the first Pod of the Pod list according to the
kubectl ByLogging sorting conditions[1].

This commit changes the cdi-deployment selector to the common
"cdi.kubevirt.io" with the value "cdi-deployment".

Since deployment selectors are immutable[2], it also adds a reconcile
callback to delete the cdi-deployment Deployment in the event of
detecting a selector that differs from the operator's desired one.

[1] https://github.com/kubernetes/kubectl/blob/fec9d5b3d/pkg/util/podutils/podutils.go#L96
[2] https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#selector

Signed-off-by: Adi Aloni <aaloni@redhat.com>

Pull Request Pull Request #3692: Fix cdi-deployment Deployment selector

Run Details

24 of 34 new or added lines in 2 files covered. (70.59%)

6 existing lines in 2 files now uncovered.

16822 of 28349 relevant lines covered (59.34%)

0.66 hits per line