ensdomains / namechain / 14352443937

78%

Build Type

push

github

Committed by web-flow

Commit Message

feat: unified registry (#29)

* feat: unified registry

* refactor: separate out the permissions in ethregistrar

* refactor: RegistryMetadata back to being an interface

refactor: removed setUri() method

* fix: path to file

* refactor: remove flags

* fix: tests

* feat: allow anyone with renew role on the token to renew it

* refactor: add metadata parameter to L1ETHRegistry constructor

* feat: added role for setting token observer

* refactor: role values are private to avoid bytecode bloat

* fix: tests

* feat: tokenIdResource() now takes a versioning param, allowing us to easily reset resource roles when we want

* refactor: more efficient token id versioning

* refactor: simplify logic

* Update contracts/src/registry/PermissionedRegistry.sol

Co-authored-by: Nick Johnson <arachnid@notdot.net>

* feat: custom toles modifier to check for expired token as well as roles

* fix: tests

* chore: work towards token id regen

* chore: work on regenerating token id when roles change

* chore: work on canonical token id and regeneration

* refactor: override _update instead of _mint and _burn

* refactor: final changes to get things working, tests wip

* fix: logic error in registry datastore

* chore: work towards solving token id issue

* feat: allow to disable eac callbacks when needed

test: all passing again

* refactor: improve callback logic

* refactor: updates based on review feedback

* feat: allow for deployer role customization

* test: fix failing tests

* refactore: shift common stuff into IRegistry

* refactor: rename methods to getter pattern

* docs: add doc comments

* refactor: create standard registry interface

* refactor: fixes based on feedback

* Update contracts/src/registry/PermissionedRegistry.sol

Co-authored-by: Nick Johnson <arachnid@notdot.net>

* refactor: shift token observer into its own file

* refactor: restrict roles for owner in ethregistrar register() method

* refactor: shift roles into mixin

---------

Co-aut... (continued)

Run Details

63 of 108 branches covered (58.33%)

Branch coverage included in aggregate %.

221 of 228 new or added lines in 13 files covered. (96.93%)

3 existing lines in 1 file now uncovered.

592 of 785 relevant lines covered (75.41%)

40.68 hits per line