• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

unicode-org / icu4x / 14340781519
73%

Build:
DEFAULT BRANCH: main
Ran 08 Apr 2025 06:32PM UTC
Jobs 1
Files 966
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

08 Apr 2025 06:20PM UTC coverage: 73.034% (+0.03%) from 73.005%
14340781519

push

github

web-flow
Segmenter cleanups, part 2 (reduce trait complexity) (#6417)

First set of followups after
https://github.com/unicode-org/icu4x/pull/6409

This:

 - Removes lifetimes and `?Sized` from the BreakType traits
- Coalesces the BreakType markers into a single set of RuleBreakTypeFoo
markers
 - Makes LineBreakType depend on RuleBreakType
 - Adds a new WordBreakType that depends on RuleBreakType


previously the wordbreaktype distinction was awkwardly handled by
`unreachable!()`s and trait impls; which meant it was not
straightforward to make WordBreak use RuleBreakType instead of
WordBreakType. Moving that required moving it to a function, but it
seemed to work well.

This does not intend to finalize the module structure, it's still doing
cleanups, I didn't wish to have these be blocked on module structure
decisions.

A cleanup I may make is to use a secondary type parameter on
RuleBReakIterator instead of a function pointer. It ought not matter,
though.



<!--
Thank you for your pull request to ICU4X!

Reminder: try to use [Conventional
Comments](https://conventionalcomments.org/) to make comments clearer.

Please see
https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for
general
information on contributing to ICU4X.
-->

18 of 30 new or added lines in 3 files covered. (60.0%)

6 existing lines in 5 files now uncovered.

57820 of 79169 relevant lines covered (73.03%)

835343.25 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
3
80.53
0.94% components/segmenter/src/line.rs
3
68.12
0.39% components/segmenter/src/word.rs
6
84.44
11.91% components/segmenter/src/rule_segmenter.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
78.43
-0.49% components/datetime/src/provider/skeleton/helpers.rs
1
88.29
-0.45% components/locale/src/expander.rs
1
80.53
0.94% components/segmenter/src/line.rs
1
84.44
11.91% components/segmenter/src/rule_segmenter.rs
2
84.25
-1.37% provider/source/src/cldr_cache.rs
Jobs
ID Job ID Ran Files Coverage
1 14340781519.1 08 Apr 2025 06:32PM UTC 966
73.03
GitHub Action Run
Source Files on build 14340781519
  • Tree
  • List 966
  • Changed 16
  • Source Changed 10
  • Coverage Changed 14
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #14340781519
  • e4db8844 on github
  • Prev Build on main (#14339379227)
  • Next Build on main (#14341251981)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc