kubevirt / hyperconverged-cluster-operator / 14340433568

82%

main: 76%

Build Type

push

github

Committed by web-flow

Commit Message

Fix a bug when setting a CPU quentity without a type (#3388)

When setting, for example, the
`spec.resourceRequirements.storageWorkloads.limit` field to `"1.5"`, the
client set the value in CDI to `"1500m"`. Then HCO will always find this
value as not matches to the required value of `"1.5"`, and will
constantly try to update CDI.

This PR fixes this issue by turning the required objects to json and back
to objects. The json marshaling peforms the same change in the object.
Now when HCO will compare the required value with the existing one, both
will be at the newer format, with the quntity type, and HCO will
understand that no change was done, and it will not try to update the CR
again.

Also. This PR adds a mutex protection to the cache in the operand
handlers.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Co-authored-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

Run Details

48 of 53 new or added lines in 6 files covered. (90.57%)

2 existing lines in 1 file now uncovered.

5508 of 6523 relevant lines covered (84.44%)

0.94 hits per line