• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubevirt / hyperconverged-cluster-operator / 14340433568
82%
main: 76%

Build:
Build:
LAST BUILD BRANCH: bump_MIGRATION_OPERATOR_v0.0.14_main
DEFAULT BRANCH: main
Ran 08 Apr 2025 06:07PM UTC
Jobs 1
Files 54
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

08 Apr 2025 06:02PM UTC coverage: 84.44% (-0.004%) from 84.444%
14340433568

push

github

web-flow
Fix a bug when setting a CPU quentity without a type (#3388)

When setting, for example, the
`spec.resourceRequirements.storageWorkloads.limit` field to `"1.5"`, the
client set the value in CDI to `"1500m"`. Then HCO will always find this
value as not matches to the required value of `"1.5"`, and will
constantly try to update CDI.

This PR fixes this issue by turning the required objects to json and back
to objects. The json marshaling peforms the same change in the object.
Now when HCO will compare the required value with the existing one, both
will be at the newer format, with the quntity type, and HCO will
understand that no change was done, and it will not try to update the CR
again.

Also. This PR adds a mutex protection to the cache in the operand
handlers.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Co-authored-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

48 of 53 new or added lines in 6 files covered. (90.57%)

2 existing lines in 1 file now uncovered.

5508 of 6523 relevant lines covered (84.44%)

0.94 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
91.51
-1.2% controllers/operands/aaq.go
3
80.49
-2.41% controllers/operands/deploymentHandler.go

Uncovered Existing Lines

Lines Coverage ∆ File
2
95.35
-0.62% controllers/operands/ssp.go
Jobs
ID Job ID Ran Files Coverage
1 14340433568.1 08 Apr 2025 06:07PM UTC 54
84.44
GitHub Action Run
Source Files on build 14340433568
  • Tree
  • List 54
  • Changed 6
  • Source Changed 0
  • Coverage Changed 6
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 736ed8b1 on github
  • Prev Build on release-1.13 (#14190743993)
  • Next Build on release-1.13 (#14601587375)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc