evilmartians / lefthook / 14331394303

76%

Build Type

push

github

Committed by web-flow

Commit Message

fix: fix command execution error on Windows #989 (#992)

* fix: fix command execution error on Windows #989
// This commit fixes an issue where Lefthook was unable to execute commands

- changed:   internal/lefthook/runner/exec/execute_windows.go
  fix: fullPathSh: change `sh.exe` for git bash installed in other directories
  fix: execute: cmdStr is dont escpape filename double quote, so replace
			    these to escaped double quote

* fix(Execute): fallback to Git-based paths when sh.exe is missing

Resolved a bug where sh.exe couldn't be found, causing shell command execution to fail.
Introduced helper functions `getFullPathSh` and `findExecutableDir` to locate sh.exe
via git-bash.exe, git.exe, or a default Git installation directory.

This ensures `CommandExecutor.Execute` works in environments where sh.exe is not in PATH.

Additional context:
- When git-bash.exe is found in a directory, sh.exe typically exists in its "bin" subdirectory.
- When git.exe is located at ".../cmd/git.exe", sh.exe is often found at the corresponding".

Run Details

27 of 43 new or added lines in 1 file covered. (62.79%)

19 existing lines in 1 file now uncovered.

3332 of 4442 relevant lines covered (75.01%)

3.25 hits per line