14322798410
92%
main: 92%

Ran 08 Apr 2025 01:17AM UTC

Jobs 1

Files 178

Run time 2min

Badge

Embed ▾

Committed 08 Apr 2025 01:08AM UTC coverage: 91.484% (-0.008%) from 91.492%

Build # 14322798410

Build Type

push

github

Committed by

bradh352

Commit Message

Fix polling ares_event_configchg_init: initialize mutex (#974)

The polling-based implementation of ares_event_configchg_init previously
did not initialize the mutex ares_event_configchg_t->lock. This caused
ares_thread_cond_timedwait to immediately return, which means that the
thread running ares_event_configchg_thread is busy-waiting without
sleeping between config change checks. In addition to the high CPU usage
this causes, the DNS config is actually never checked in this case.

This commit fixes the issue by initializing the mutex. Thereby, the
config polling thread correctly only wakes up every 30 seconds and
properly checks for a config change.

Note: the bug only came into effect if the combination of the polling-
based implementation of ares_event_configchg_init and the pthread-based
implementation of ares_thread_cond_timedwait was used.

Fix By: Florian Pfisterer (@FlorianPfisterer)

Run Details

22399 of 24484 relevant lines covered (91.48%)

11828.47 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	86.67	-0.61%	src/lib/dsa/ares_array.c
1	63.65	-0.12%	src/lib/record/ares_dns_mapping.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	14322798410.1	08 Apr 2025 01:17AM UTC	937	60.1	GitHub Action Run

c-ares / c-ares / 14322798410
92%
main: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 14322798410

c-ares / c-ares / 14322798410 92% main: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 14322798410

c-ares / c-ares / 14322798410
92%
main: 92%

README BADGES
x