tarantool
/
tarantool
/
14306176422
88%
master: 88%
master: 88%
|
Ran
|
Jobs
1
|
Files
518
|
Run time
3min
|
Badge
Embed ▾
README BADGES
|
coverage: 87.484% (+0.006%) from 87.478%
push
github
lockerbox: release array and schema in box_insert_arrow According to the documentation to the Apache Arrow C data interface: > Consumers MUST call a base structure’s release callback when they > won’t be using it anymore[^1] `box_insert_arrow()` is clearly a consumer so it must move or release the input Arrow array and schema to conform to the specification while currently it does not. This patch fixes this issue. Note that for performance reasons (to avoid extra copying), the engine callback that implements batch insertion should be allowed to move the input Arrow array and schema to a private location. To allow for that, we have to move the code that encodes the input Arrow in the IPC format for xlog from `txn_add_redo()` to `space_execute_insert_arrow()`. Closes #11338 [^1]: https://arrow.apache.org/docs/format/CDataInterface.html#release-callback-semantics-for-consumers NO_DOC=bug fix NO_CHANGELOG=batch insertion isn't implemented in CE (cherry picked from commit bf5bce363)
69941 of 123821 branches covered (56.49%)
17 of 20 new or added lines in 3 files covered. (85.0%)
55 existing lines in 21 files now uncovered.102971 of 117703 relevant lines covered (87.48%)
2173842.46 hits per line
New Missed Lines in Diff
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 1 |
95.47 |
-0.21% | src/box/space.c |
| 2 |
90.81 |
-0.59% | src/box/box.cc |
Uncovered Existing Lines
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 1 |
90.93 |
0.15% | src/box/applier.cc |
| 1 |
90.51 |
-0.63% | src/box/engine.c |
| 1 |
94.74 |
-1.75% | src/box/engine.h |
| 1 |
95.78 |
-0.12% | src/box/replication.cc |
| 1 |
95.47 |
-0.21% | src/box/space.c |
| 1 |
90.14 |
-0.08% | src/box/vy_log.c |
| 1 |
95.68 |
-0.72% | src/box/vy_point_lookup.c |
| 1 |
84.32 |
-0.01% | src/box/xlog.c |
| 1 |
87.5 |
-1.59% | src/box/xlog.h |
| 1 |
96.3 |
-3.7% | src/cpu_feature.c |
| 1 |
80.0 |
-2.5% | src/lib/core/clock.c |
| 1 |
96.55 |
-1.15% | src/lib/core/histogram.c |
| 1 |
97.05 |
-0.1% | src/lib/msgpuck/msgpuck.h |
| 2 |
92.37 |
-0.09% | src/box/vinyl.c |
| 2 |
84.53 |
-0.72% | src/lib/core/coio.c |
| 2 |
85.71 |
-9.52% | src/lib/core/tt_sigaction.c |
| 3 |
90.9 |
-0.31% | src/box/vy_scheduler.c |
| 3 |
22.64 |
-0.06% | src/lib/uri/uri_parser.c |
| 6 |
87.28 |
-0.15% | src/box/vy_run.c |
| 6 |
93.87 |
-0.75% | src/box/xrow_update_field.c |
| 18 |
90.81 |
-0.59% | src/box/box.cc |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 14306176422.1 | 518 |
87.48 |
GitHub Action Run |
