• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

wuunder / http_ex / cfee02e523b0c425b584c4002fdad57d52248b36-PR-12
85%
main: 85%

Build:
Build:
LAST BUILD BRANCH: marcel/validate-options
DEFAULT BRANCH: main
Ran 04 Apr 2025 03:16PM UTC
Jobs 1
Files 18
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

04 Apr 2025 03:10PM UTC coverage: 82.726% (-0.6%) from 83.366%
cfee02e523b0c425b584c4002fdad57d52248b36-PR-12

Pull #12

github

fatboypunk
Let logging handle pdf responses

Because:
When fetching PDF's with HTTPEx I encountered the following error:

```
[error] ** (ArgumentError) argument error
    (stdlib 6.2) io.erl:203: :io.put_chars(:standard_io, [<<27, 91, 52, 109, 72, 84, 84, 80, 32, 114, 101, 115, 112, 111, 110, 115, 101, 58, 27, 91, 50, 52, 109, 10, 10, 27, 91, 49, 109, 67, 108, 105, 101, 110, 116, 58, 27, 91, 50, 50, 109, 32, 27, 91, 51, 109, 58, 102, 105, ...>>, 10])
    (http_ex 0.1.0) lib/http_ex/logging.ex:43: HTTPEx.Logging.log/1
    (http_ex 0.1.0) lib/http_ex/logging.ex:50: HTTPEx.Logging.log/1
```

I was able to follow this back to the summary of the response, with
Michaël we looked at knowing upfront we had to do this but couldn't find
it. If there's a better way to know how to make a string out of it,
idea's are welcome.

We've now implemented a rescue for this call which uses the original
response or else tries to encode this.

Will add a test for this in a follow up.
Pull Request #12: Let logging handle pdf responses

0 of 5 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

431 of 521 relevant lines covered (82.73%)

36.81 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
5
34.78
-7.32% lib/http_ex/response.ex

Uncovered Existing Lines

Lines Coverage ∆ File
1
34.78
-7.32% lib/http_ex/response.ex
Jobs
ID Job ID Ran Files Coverage
1 cfee02e523b0c425b584c4002fdad57d52248b36-PR-12.1 04 Apr 2025 03:16PM UTC 18
82.73
GitHub Action Run
Source Files on build cfee02e523b0c425b584c4002fdad57d52248b36-PR-12
  • Tree
  • List 18
  • Changed 1
  • Source Changed 0
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Pull Request #12
  • PR Base - main (#C9092E01...)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc