tarantool / tarantool / 14266750274

88%

Build Type

push

github

Committed by sergepetrenko

Commit Message

salad: fix crash on insertion into bps tree with OOM conditions

On insertion into bps tree we first reserve blocks for the case we
need to insert new leaf during rebalancing. Next there can be a free
block on last extent in matras but no more free extents in tuple arena.
So `bps_tree_reserve_blocks()` is able to allocate a block but then
`bps_tree_garbage_push()` is called that touches a block. As there no
free extents touch is failed which is unexpected and causes a crash.

We don't need to touch the block on this path as block is newly allocated
and is not shared with any read view. We don't need to touch block on
other paths too (disposing a leaf or a inner node) because we move data
from this node before so it is already should be touched.

So just don't touch the block in `bps_tree_garbage_push()`.

The issue is introduced in the commit 51c56d9b3319 ("salad: reserve
extents for matras_touch on BPS tree operations") and unlocked in the
commit 32b0678a74ab ("memtx: reserve extents in the RTREE index itself")
where we removed crutches where we heuristically reserve memory for
index operations.

Closes #11326

NO_DOC=bugfix

Run Details

70162 of 123719 branches covered (56.71%)

1 of 1 new or added line in 1 file covered. (100.0%)

33 existing lines in 12 files now uncovered.

103259 of 118012 relevant lines covered (87.5%)

2909558.4 hits per line