dart-lang / native / 14266342043

76%

push

github

[native_assets_cli] Syntax for `assets_for_build` and `hooks/metadata` (#2163)

Bug: https://github.com/dart-lang/native/issues/1251

This PR contains the JSON spec for:

* https://github.com/dart-lang/native/pull/2164

For more details see that PR.

This PR adds the syntax for passing assets from build hooks to build hooks.

build output `assets_for_build`:

```json
{
  "assets": [],
  "assets_for_build": [
    {
      "encoding": {
        "a_key": "some_value"
      },
      "some_key": "some_value",
      "type": "some_asset_type"
    }
  ],
  "assets_for_linking": {},
}
```

build input `assets` per package name:

```json
{
  "assets": {
    "some_package": [
      {
        "some_key": "some_value",
        "type": "some_asset_type"
      }
    ]
  },
  "config": {},
}
```

Secondly, this PR adds a syntax for metadata assets (assets that cannot be bundled but just ferry information between different hooks).

```json
      {
        "encoding": {
          "key": "foo",
          "value": "bar"
        },
        "type": "hooks/metadata"
      },
```

The schemas now check these.

And this is covered by tests.

Changes to the generated schemas:

* Override the new build input `asset` and build output `assets_for_build` with the `CodeAsset` and `DataAsset` in the generated extension schemas.

Notable changes to the syntax generator:

* Enable generating tagged enum classes if there are two fields (a tag, and some `encoding`) in the super class.
* Support `Object` fields (used for `MetadataAsset.value`).

21 of 97 new or added lines in 1 file covered. (21.65%)

13837 of 16313 relevant lines covered (84.82%)

34.82 hits per line