skeema / skeema / 14254697844

92%

push

github

internal refactor: move more logic to ColumnType

This commit moves some column-type-specific logic out of the unsafe-diff-
detection code path and into the ColumnType abstraction (recently introduced
in c922e6b), for better reusability and readability.

ColumnType handling for enum/set is also improved here: the value list is no
longer treated as part of the Base type name. And a new method has been added
for obtaining unescaped/unquoted values for enum/set, which may be useful in
future linters like the enum/set related one in #216.

Some unsafe-diff explanation messages and linter annotation messages have
been tweaked slightly, but otherwise no user-facing behavior changes are
present.

109 of 109 new or added lines in 3 files covered. (100.0%)

10364 of 11119 relevant lines covered (93.21%)

1.11 hits per line